Skip to content

Fix using a non-tuple sequence for multidimensional indexing that wil…#8732

Open
aarpon wants to merge 3 commits intoProject-MONAI:devfrom
aitoo:fix/non_tuple_indexing
Open

Fix using a non-tuple sequence for multidimensional indexing that wil…#8732
aarpon wants to merge 3 commits intoProject-MONAI:devfrom
aitoo:fix/non_tuple_indexing

Conversation

@aarpon
Copy link

@aarpon aarpon commented Feb 5, 2026

Fix using a non-tuple sequence for multidimensional indexing that will result in error in pytorch 2.9.

Fixes # .

Description

The SlidingWindowInferer complains that from PyTorch 2.9, using non-tuple sequences to slice into Tensors will result in an error (or, worse, misbehave). This patch targets all places in monai/inferers/utils.py where indexing may happen with lists or other types of sequences.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR updates monai/inferers/utils.py to normalize tensor indexing across sliding-window inference by converting list-based indices to tuples. Changes apply to batched and non-batched paths when gathering window data and conditions, updating the sliding-window device buffer and final outputs, and when accumulating patch contributions in _compute_coords. No public API signatures are changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the main change: fixing non-tuple sequence indexing for PyTorch 2.9 compatibility in tensor operations.
Description check ✅ Passed Description covers the issue, solution, and includes required testing checkboxes. Key sections present: problem statement, description, and types of changes with test verification.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

aarpon added 2 commits February 5, 2026 18:35
@aarpon
Fix formatting.
922dfff
@aarpon
DCO Remediation Commit for Aaron Ponti <aaron@aaronponti.ch>
57ffb77 
I, Aaron Ponti <aaron@aaronponti.ch>, hereby add my Signed-off-by to this commit: f6673fa
I, Aaron Ponti <aaron@aaronponti.ch>, hereby add my Signed-off-by to this commit: 922dfff

Signed-off-by: Aaron Ponti <aaron@aaronponti.ch>
@ericspod
Copy link
Member

ericspod commented Feb 26, 2026

Hi @aarpon thanks for these fixes, I know tuple indices are needed in places more strictly than in the past. Would it make sense to use ensure_tuple in these places however? I don't think we should be doing the same tuple(p) if isinstance(p, list) else p everywhere, this should be condensed to a function but I think ensure_tuple does this already. This also covers cases where p isn't a list but some other iterable that should be converted to a tuple. If you agree please update and we can rereview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KumoLiu KumoLiu Awaiting requested review from KumoLiu KumoLiu is a code owner

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aarpon @ericspod